From 86fe14b730ae08d1e87fcef3cd609cd1db12bc70 Mon Sep 17 00:00:00 2001 From: rnentjes Date: Sun, 25 Jan 2026 19:26:37 +0100 Subject: [PATCH] Refactor MidiMessage type initialization and add TimedMidiMessage test Updated `MidiMessage` to initialize with `MIDI_TIMED` type. Introduced `TimedMidiMessageTest` for testing serialization and validation logic. Updated `.gitignore` to include `.idea` directory. --- .gitignore | 1 + .../kotlin/nl/astraeus/midi/message/MidiMessage.kt | 11 ++--------- .../astraeus/midi/message/TimedMidiMessageTest.kt | 13 +++++++++++++ 3 files changed, 16 insertions(+), 9 deletions(-) create mode 100644 src/commonTest/kotlin/nl/astraeus/midi/message/TimedMidiMessageTest.kt diff --git a/.gitignore b/.gitignore index 35b4a7f..fbd064a 100644 --- a/.gitignore +++ b/.gitignore @@ -45,3 +45,4 @@ bin/ .kotlin kotlin-js-store gradle.properties +.idea diff --git a/src/commonMain/kotlin/nl/astraeus/midi/message/MidiMessage.kt b/src/commonMain/kotlin/nl/astraeus/midi/message/MidiMessage.kt index 2eb8152..3184a0b 100644 --- a/src/commonMain/kotlin/nl/astraeus/midi/message/MidiMessage.kt +++ b/src/commonMain/kotlin/nl/astraeus/midi/message/MidiMessage.kt @@ -1,13 +1,6 @@ package nl.astraeus.midi.message -import nl.astraeus.tba.DataType -import nl.astraeus.tba.MutableByteArrayHandler -import nl.astraeus.tba.SlicedByteArray -import nl.astraeus.tba.Type -import nl.astraeus.tba.TypedByteArray -import nl.astraeus.tba.blob -import nl.astraeus.tba.double -import nl.astraeus.tba.long +import nl.astraeus.tba.* open class MidiMessage( vararg types: Type @@ -54,7 +47,7 @@ class TimedMidiMessage() : MidiMessage( var readIndex: Int = 0 init { - this.type = MidiMessageTypes.MIDI_DATA.typeId + this.type = MidiMessageTypes.MIDI_TIMED.typeId } constructor(data: ByteArray): this() { diff --git a/src/commonTest/kotlin/nl/astraeus/midi/message/TimedMidiMessageTest.kt b/src/commonTest/kotlin/nl/astraeus/midi/message/TimedMidiMessageTest.kt new file mode 100644 index 0000000..cc9982f --- /dev/null +++ b/src/commonTest/kotlin/nl/astraeus/midi/message/TimedMidiMessageTest.kt @@ -0,0 +1,13 @@ +package nl.astraeus.midi.message + +import kotlin.test.Test + +class TimedMidiMessageTest { + + @Test + fun testDefinitionSize() { + val message = TimedMidiMessage(0.0, 0, 0, 0) + val byteArray = message.data.buffer.toByteArray() + val message2 = TimedMidiMessage(byteArray) + } +}